Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: only rechunk once per aggregate #16469

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented May 24, 2024

Fixes #16457.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 79.66102% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 81.45%. Comparing base (ee25cb7) to head (1810dbc).
Report is 5 commits behind head on main.

Files Patch % Lines
...s-core/src/frame/group_by/aggregations/dispatch.rs 79.66% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16469      +/-   ##
==========================================
- Coverage   81.46%   81.45%   -0.02%     
==========================================
  Files        1409     1409              
  Lines      184722   184746      +24     
  Branches     2971     2971              
==========================================
- Hits       150491   150489       -2     
- Misses      33711    33737      +26     
  Partials      520      520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 6de7422 into pola-rs:main May 24, 2024
22 checks passed
jqnatividad added a commit to dathere/qsv that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example of .over() 900x slower than group_by.agg.join (and over 50x slower than pandas)
2 participants