-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python, rust): implement unique counts for boolean datatype #16588
base: main
Are you sure you want to change the base?
feat(python, rust): implement unique counts for boolean datatype #16588
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16588 +/- ##
==========================================
- Coverage 81.37% 81.34% -0.04%
==========================================
Files 1425 1424 -1
Lines 187669 187226 -443
Branches 2702 2698 -4
==========================================
- Hits 152720 152301 -419
+ Misses 34453 34429 -24
Partials 496 496 ☔ View full report in Codecov by Sentry. |
f92c262
to
7966d1d
Compare
c8a3785
to
43c198d
Compare
return IdxCa::new(ca.name(), [] as [IdxSize; 0]); | ||
} | ||
|
||
let ca = ca.rechunk(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritchie46 can answer better here, but I think if we're spending the energy rechunking a series (which mem copies), the original array should receive the benefit as well, which you can do by making ca
mut
and calling *ca.rechunk()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be. However, I can't see this being done anywhere else in the codebase, which makes me question whether it should be done, so will wait for Ritchie's answer.
I guess you meant @ritchie46 btw.
CodSpeed Performance ReportMerging #16588 will not alter performanceComparing Summary
|
e599f83
to
0473baa
Compare
cc9f4ef
to
5940035
Compare
5940035
to
fb08134
Compare
@ritchie46 I could make some simplifications in the code when the unique count is 1 (see 38ff3bf for details). Were there any other particular use cases for this trait that you thought of? If so its not immediately apparent to me as I think we still need the actual counts and order. |
38ff3bf
to
2f34e60
Compare
Closes #16356