feat!: Remove deprecated top_k parameters nulls_last, maintain_order, and multithreaded
#16599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
stinodego
changed the title
top_k parameters, update behavior with regard to nulls
github-actions
bot
added
breaking
stinodego
changed the title
top_k parameters, update behavior with regard to nullstop_k parameters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16599 +/- ##
========================================
Coverage 81.45% 81.46%
========================================
Files 1413 1413
Lines 186306 186175 -131
Branches 2777 2759 -18
========================================
- Hits 151750 151659 -91
+ Misses 34036 34011 -25
+ Partials 520 505 -15 ☔ View full report in Codecov by Sentry. |
stinodego
changed the title
top_k parameterstop_k parameters nulls_last, maintain_order, and multithreaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15238
Changes
top_kand related methods.This does not introduce/fix the behavior with regards to nulls (#16748), it simply enforces the deprecation.