Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Mark min_periods as keyword-only for rolling methods #16738

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

stinodego
Copy link
Member

Closes #16684

This aligns the rolling_* and rolling_*_by methods. This is not breaking as the methods are marked as unstable.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (ddf8126) to head (61ebd76).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16738      +/-   ##
==========================================
- Coverage   81.45%   81.43%   -0.02%     
==========================================
  Files        1413     1413              
  Lines      186096   186183      +87     
  Branches     2776     2776              
==========================================
+ Hits       151588   151622      +34     
- Misses      33988    34041      +53     
  Partials      520      520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit e75ece9 into main Jun 5, 2024
15 checks passed
@stinodego stinodego deleted the min-periods-kw-only branch June 5, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] min_periods should be a named argument or not?
1 participant