Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize sort for String and Binary types #16871

Merged
merged 2 commits into from
Jun 11, 2024
Merged

perf: Optimize sort for String and Binary types #16871

merged 2 commits into from
Jun 11, 2024

Conversation

ritchie46
Copy link
Member

Sort by the views directly and go through the whole constructors, leaving the buffers as is.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jun 11, 2024
Copy link

codspeed-hq bot commented Jun 11, 2024

CodSpeed Performance Report

Merging #16871 will improve performances by 15.75%

Comparing sort (b00f613) with main (806feb5)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main sort Change
test_groupby_h2oai_q3 2.7 ms 2.4 ms +15.75%

@ritchie46 ritchie46 merged commit ff34c69 into main Jun 11, 2024
24 of 26 checks passed
@ritchie46 ritchie46 deleted the sort branch June 11, 2024 09:38
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
@stinodego stinodego changed the title perf: Optimize string/binary sort perf: Optimize sort for String and Binary types Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants