Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Set up some of the infrastructure for new streaming engine #16900

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jun 12, 2024
@ritchie46 ritchie46 changed the title refactor: setup skeleton feat: setup skeleton Jun 12, 2024
@github-actions github-actions bot added the enhancement New feature or an improvement of an existing feature label Jun 12, 2024
Copy link

codspeed-hq bot commented Jun 12, 2024

CodSpeed Performance Report

Merging #16900 will improve performances by 21%

Comparing skelet (5daf4a1) with main (cd68100)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main skelet Change
test_groupby_h2oai_q2 5.3 ms 4.4 ms +21%

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 29.85075% with 47 lines in your changes missing coverage. Please review.

Project coverage is 80.99%. Comparing base (6ed624f) to head (5daf4a1).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/polars-stream/src/skeleton.rs 0.00% 27 Missing ⚠️
crates/polars-expr/src/planner.rs 0.00% 16 Missing ⚠️
crates/polars-lazy/src/frame/mod.rs 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16900      +/-   ##
==========================================
- Coverage   81.44%   80.99%   -0.45%     
==========================================
  Files        1425     1434       +9     
  Lines      187970   189002    +1032     
  Branches     2704     2704              
==========================================
- Hits       153087   153083       -4     
- Misses      34386    35422    +1036     
  Partials      497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit debcade into main Jun 12, 2024
27 checks passed
@ritchie46 ritchie46 deleted the skelet branch June 12, 2024 14:52
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
@stinodego stinodego changed the title feat: setup skeleton refactor: Set up framework for new streaming engine Jun 30, 2024
@stinodego stinodego changed the title refactor: Set up framework for new streaming engine refactor: Set up some of the infrastructure for new streaming engine Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants