-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Support Decimal inputs for lit
#16950
Conversation
Closes #13341 👍 |
} else if value.get_type().qualname().unwrap() == "Decimal" { | ||
let av = py_object_to_any_value(value, true)?; | ||
Ok(Expr::Literal(LiteralValue::try_from(av).unwrap()).into()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parsing logic for lit
should be unified with that of AnyValue
. For now, this works...
CodSpeed Performance ReportMerging #16950 will improve performances by 27.51%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16950 +/- ##
==========================================
+ Coverage 80.96% 80.98% +0.01%
==========================================
Files 1445 1445
Lines 189916 189925 +9
Branches 2712 2712
==========================================
+ Hits 153771 153803 +32
+ Misses 35645 35623 -22
+ Partials 500 499 -1 ☔ View full report in Codecov by Sentry. |
Closes #13341
Previously, passing Python Decimal objects to
lit
was unsupported. Now it works: