fix: Properly set FAST_EXPLODE_LIST metadata
#16951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
github-actions
bot
added
fix
|
Can you add a test for this? |
Fixes pola-rs#16923. This resolves very dumb mistake (I made), where the `FAST_EXPLODE_LIST` was only ever set to `true` when calling `set_fast_explode_list`. We now use `set` instead of `insert`.
coastalwhite
force-pushed
the
fix-md-fast-explode-16923
branch
from
aceb7ba to
314d166
Compare
coastalwhite
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16951 +/- ##
==========================================
- Coverage 80.97% 80.96% -0.02%
==========================================
Files 1445 1445
Lines 189825 189922 +97
Branches 2712 2712
==========================================
+ Hits 153717 153769 +52
- Misses 35608 35654 +46
+ Partials 500 499 -1 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jun 14, 2024
|
@coastalwhite @ritchie46 thanks for the fix guys! Any idea when the next preview release is, or are we straight to v1.0 after this? |
stinodego
changed the title
FAST_EXPLODE_LIST metadataFAST_EXPLODE_LIST metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16923.
This resolves very dumb mistake (I made), where the
FAST_EXPLODE_LISTwas only ever set totruewhen callingset_fast_explode_list.We now use
setinstead ofinsert.