Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Harden "async" check for users with out-of-date sqlalchemy libraries #17029

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jun 17, 2024

Closes #17022.

  • Hardens async checks for sqlalchemy connections so they are resilient to old library versions (that do not actually implement any such support).

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jun 17, 2024
@alexander-beedie alexander-beedie added the A-io-database Area: reading/writing to databases label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (69e3824) to head (3ada45e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17029      +/-   ##
==========================================
+ Coverage   81.00%   81.02%   +0.01%     
==========================================
  Files        1448     1448              
  Lines      190543   190551       +8     
  Branches     2722     2723       +1     
==========================================
+ Hits       154357   154393      +36     
+ Misses      35683    35655      -28     
  Partials      503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@alexander-beedie alexander-beedie merged commit de45530 into pola-rs:main Jun 17, 2024
19 checks passed
@alexander-beedie alexander-beedie deleted the alchemy-async-check branch June 17, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-io-database Area: reading/writing to databases fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import name 'async_sessionmaker' from 'sqlalchemy.ext.asyncio' in 1.0.0a1
2 participants