Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Update exception imports in test suite #17035

Merged
merged 6 commits into from
Jun 17, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 17, 2024

In a lot of cases, exceptions were already imported from the exceptions module directly. Now we do this consistently across the test suite, instead of using the top-level re-exports (I want to get rid of those - more info in later PR).

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Jun 17, 2024
@stinodego stinodego marked this pull request as ready for review June 17, 2024 23:17
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.01%. Comparing base (a62ab75) to head (cd20366).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17035      +/-   ##
==========================================
+ Coverage   80.98%   81.01%   +0.02%     
==========================================
  Files        1448     1448              
  Lines      190551   190551              
  Branches     2723     2723              
==========================================
+ Hits       154322   154366      +44     
+ Misses      35726    35682      -44     
  Partials      503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 1f15e1c into main Jun 17, 2024
14 of 15 checks passed
@stinodego stinodego deleted the no-exceptions-reexport branch June 17, 2024 23:34
@c-peters c-peters added the accepted Ready for implementation label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants