depr(python): Remove re-export of exceptions at top-level #17059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the top-level re-exports has some minor benefits:
exceptions
module and the exceptions themselves. We should pick one.exceptions
module (I straightened this out recently). This is a bad user experience.Drawbacks:
pl.ComputeError
is quite convenient (thoughpl.exceptions.ComputeError
isn't that much harder).except pl.ComputeError
, andthis (loudly) breaks their codethey will get a deprecation message.For reference, pandas and NumPy also have a dedicated module for their exceptions and do not re-export at the top-level (NumPy only does for backward compatibility).
Example
Before:
Use instead: