-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(python): Remove re-export of data type groups #17073
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17073 +/- ##
==========================================
- Coverage 80.86% 80.86% -0.01%
==========================================
Files 1455 1456 +1
Lines 191086 191108 +22
Branches 2723 2725 +2
==========================================
+ Hits 154519 154530 +11
- Misses 36063 36074 +11
Partials 504 504 ☔ View full report in Codecov by Sentry. |
So I can still do |
You can, but don't count on it. These are not meant to be public, and in fact they never really were (not documented in the API reference). |
Ah this breaks patito on import error :P @stinodego |
They were importing directly from the As a temporary workaround, they can import from It's expected that some downstream packages will break on a major release. Let's hope everyone manages to upgrade quickly and their code is better for it. |
@stinodego for now indeed it's migrated to .group, see here: JakobGM/patito#74 I understand! Just wanted to make you aware 😄 |
Changes
INTEGER_DTYPES
,FLOAT_DTYPES
, etc. from the top-level anddatatypes
modulecs.integer()
instead ofpl.col(pl.INTEGER_DTYPES)
).