Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support top-level pl.col autocompletion for iPython #17080

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jun 20, 2024

This just fixes the top-level

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.87%. Comparing base (235ebee) to head (c11bbd1).
Report is 2 commits behind head on main.

Current head c11bbd1 differs from pull request most recent head f8205a5

Please upload reports for the commit f8205a5 to get more accurate results.

Files Patch % Lines
py-polars/polars/functions/col.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17080      +/-   ##
==========================================
+ Coverage   80.86%   80.87%   +0.01%     
==========================================
  Files        1455     1455              
  Lines      191086   191088       +2     
  Branches     2723     2723              
==========================================
+ Hits       154519   154547      +28     
+ Misses      36063    36038      -25     
+ Partials      504      503       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion changed the title try removing metaclass from ColumnFactory feat: Support pl.col autocompletion for iPython Jun 20, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 20, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review June 20, 2024 09:11
@ritchie46 ritchie46 merged commit be392c4 into pola-rs:main Jun 20, 2024
14 checks passed
@nameexhaustion nameexhaustion deleted the col-completion branch June 20, 2024 09:24
@nameexhaustion nameexhaustion changed the title feat: Support pl.col autocompletion for iPython feat: Support top-level pl.col autocompletion for iPython Jun 20, 2024
@nameexhaustion nameexhaustion self-assigned this Jun 24, 2024
@c-peters c-peters added the accepted Ready for implementation label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants