Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add missing spaces in cargo.toml #17145

Merged
merged 2 commits into from
Jun 23, 2024
Merged

chore: Add missing spaces in cargo.toml #17145

merged 2 commits into from
Jun 23, 2024

Conversation

mcrumiller
Copy link
Contributor

@mcrumiller mcrumiller commented Jun 23, 2024 •
edited
Loading

See 5cad69e#r143437580, this is causing CI to fail. dprint didn't like the formatting, the following was fixed:

  • spaces around workspace = true
  • dependency sections, which can be separated by newlines, must be in alphabetical order. polars-stream was listed after polars-utils which it didn't like.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jun 23, 2024
@mcrumiller mcrumiller marked this pull request as draft June 23, 2024 15:49
@mcrumiller mcrumiller marked this pull request as ready for review June 23, 2024 15:56
mcrumiller referenced this pull request Jun 23, 2024
@ritchie46
ci: Add polars-stream
5cad69e
MarcoGorelli
MarcoGorelli approved these changes Jun 23, 2024
View reviewed changes
Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mcrumiller ! looks like this fixes the failing CI job

merging then to get CI green again

@MarcoGorelli MarcoGorelli merged commit 232d557 into pola-rs:main Jun 23, 2024
14 checks passed
@mcrumiller mcrumiller deleted the spaces branch June 23, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcrumiller @MarcoGorelli