Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): properly check the BMI2 uleb128 #17191

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Jun 25, 2024
@ritchie46
Copy link
Member

closes #17175 right?

@coastalwhite
Copy link
Collaborator Author

I don't think so. This was not something I found when trying to debug that issue, it was something I found when trying to optimize the parquet reader.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (4731834) to head (e00db75).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17191      +/-   ##
==========================================
- Coverage   80.94%   80.81%   -0.13%     
==========================================
  Files        1464     1464              
  Lines      191928   192019      +91     
  Branches     2742     2743       +1     
==========================================
- Hits       155349   155183     -166     
- Misses      36070    36325     +255     
- Partials      509      511       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 332e40a into pola-rs:main Jun 25, 2024
22 checks passed
@coastalwhite coastalwhite deleted the fix-uleb128-bmi branch June 25, 2024 15:28
@c-peters c-peters added the accepted Ready for implementation label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants