Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow no-op round/ceil/floor on integer types #17241

Merged
merged 1 commit into from
Jun 27, 2024
Merged

feat: Allow no-op round/ceil/floor on integer types #17241

merged 1 commit into from
Jun 27, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jun 27, 2024

Fixes #17240.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 27, 2024
@ritchie46 ritchie46 merged commit c45e5ec into main Jun 27, 2024
20 checks passed
@ritchie46 ritchie46 deleted the noop-int-round branch June 27, 2024 11:52
@stinodego stinodego changed the title feat: allow no-op round/ceil/floor on int types feat: Allow no-op round/ceil/floor on integer types Jun 28, 2024
@orlp orlp mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support No-op round() on Int columns
2 participants
@orlp @ritchie46