Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Ensure we don't close extant adbc connections in write_database #17298

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jun 29, 2024

Closes #17293.

Extant ADBC connections were implicitly closed in write_database via context manager; fixed, and added coverage.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jun 29, 2024
@alexander-beedie alexander-beedie added the A-io-database Area: reading/writing to databases label Jun 29, 2024
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.73%. Comparing base (d444b79) to head (f8b5968).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17298      +/-   ##
==========================================
+ Coverage   80.72%   80.73%   +0.01%     
==========================================
  Files        1475     1475              
  Lines      193162   193162              
  Branches     2751     2751              
==========================================
+ Hits       155922   155948      +26     
+ Misses      36732    36706      -26     
  Partials      508      508              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 00abd02 into pola-rs:main Jun 30, 2024
16 checks passed
@alexander-beedie alexander-beedie deleted the fix-adbc-connection-close branch June 30, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-io-database Area: reading/writing to databases fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write_database closes adbc connection
2 participants