refactor(rust): Prefer ParquetError::oos to ParquetError::OutOfSpec #17314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are mixed uses of
ParquetError::oos
andParquetError::OutOfSpec
where it would just be clearer to pick one. So I favored the convenience constructor that saves a few keystrokes. I didn't make changes to the tests because that requires makingpub fn oos(..)
and I am not sure if people want that API to be exposed. If we made that change, there would be a few dozen more references cleaned up.(This is my first commit to Polars - I'm doing some minor refactors to get my bearings so I can implement some improvements I need at work)