-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python): Fix handling of TextIOWrapper in write_csv #17328
Conversation
47087f5
to
d440c5f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17328 +/- ##
==========================================
- Coverage 80.72% 80.69% -0.03%
==========================================
Files 1475 1476 +1
Lines 193388 193497 +109
Branches 2760 2759 -1
==========================================
+ Hits 156117 156151 +34
- Misses 36761 36836 +75
Partials 510 510 ☔ View full report in Codecov by Sentry. |
Thanks, can you add a test that showed the issue before this fix? |
d440c5f
to
0617cc4
Compare
Added |
It is not necessary to extract |
14f102b
to
dcfea28
Compare
c775b62
to
15ae286
Compare
I'm sorry that there was a bug in #17315, namely the handling of Now |
15ae286
to
784241c
Compare
Because the requirement of encoding has become more strict, |
fc86c7d
to
f57d8e5
Compare
Non-UTF8 files are now denied
f57d8e5
to
3181915
Compare
Fixes "write to closed file" in
write_csv
: