refactor: Add reduce ComputeNode in new streaming engine
#17389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
changed the title
ComputeNode in new streaming engine
github-actions
bot
added
internal
orlp
requested changes
Jul 17, 2024
crates/Makefile
Outdated
| @@ -10,7 +10,7 @@ fmt: ## Run rustfmt and dprint | |||
|
|
|||
| .PHONY: check | |||
| check: ## Run cargo check with all features | |||
| cargo check -p polars --all-features | |||
| cargo check -p polars --all-features -p polars-stream | |||
There was a problem hiding this comment.
Was this supposed to be part of the PR?
There was a problem hiding this comment.
Maybe.. Then we can ensure that all warnings are fixed. But if CI doesn't like it, I will remove it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17389 +/- ##
==========================================
- Coverage 80.62% 80.45% -0.18%
==========================================
Files 1490 1498 +8
Lines 195995 196415 +420
Branches 2789 2789
==========================================
- Hits 158030 158028 -2
- Misses 37452 37874 +422
Partials 513 513 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.