fix(python): Fix a global variable table-discovery edge case for the SQL interface
#17400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17400 +/- ##
==========================================
+ Coverage 80.72% 80.75% +0.02%
==========================================
Files 1475 1475
Lines 193388 193388
Branches 2760 2760
==========================================
+ Hits 156117 156167 +50
+ Misses 36761 36711 -50
Partials 510 510 ☔ View full report in Codecov by Sentry. |
stinodego
approved these changes
Jul 3, 2024
|
The rare one-character fix 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17398.
Simple fix, though a better one would be having the underlying parser analyse the statement and extract the tables properly; I'll look into doing that at a later date (am on vacation at the moment ;)