Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Improve error message when passing string key to Series.__getitem__ #17408

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

stinodego
Copy link
Contributor

Closes #17402

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jul 3, 2024
@stinodego stinodego marked this pull request as ready for review July 3, 2024 16:59
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (09c98c5) to head (9a86e28).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17408      +/-   ##
==========================================
- Coverage   80.74%   80.74%   -0.01%     
==========================================
  Files        1475     1475              
  Lines      193388   193393       +5     
  Branches     2760     2760              
==========================================
- Hits       156155   156154       -1     
- Misses      36723    36729       +6     
  Partials      510      510              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit f803053 into main Jul 4, 2024
15 checks passed
@stinodego stinodego deleted the getitem-error-msg branch July 4, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indexing a Series object with a string raises a confusing TypeError.
1 participant