Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Support sa session #17435

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

phi-friday
Copy link
Contributor

@phi-friday phi-friday changed the title fix(python): support sa session fix(python): Support sa session Jul 5, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars and removed title needs formatting labels Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.68%. Comparing base (f803053) to head (e942b2c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17435      +/-   ##
==========================================
- Coverage   80.68%   80.68%   -0.01%     
==========================================
  Files        1476     1476              
  Lines      193490   193495       +5     
  Branches     2760     2762       +2     
==========================================
- Hits       156126   156125       -1     
- Misses      36854    36861       +7     
+ Partials      510      509       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Jul 5, 2024

Ahhh... I see we handle this correctly for reading, but missed it for writing.
The fix looks good to me, but needs a unit test.

...which I see you just added as I posted this; nice 😎👍

Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI is green after the tests run, looks good to merge

@ritchie46 ritchie46 merged commit 909fa88 into pola-rs:main Jul 5, 2024
12 of 13 checks passed
@phi-friday phi-friday deleted the fix-support-sa-session branch July 5, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants