-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python): Support sa session #17435
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17435 +/- ##
==========================================
- Coverage 80.68% 80.68% -0.01%
==========================================
Files 1476 1476
Lines 193490 193495 +5
Branches 2760 2762 +2
==========================================
- Hits 156126 156125 -1
- Misses 36854 36861 +7
+ Partials 510 509 -1 ☔ View full report in Codecov by Sentry. |
Ahhh... I see we handle this correctly for reading, but missed it for writing. ...which I see you just added as I posted this; nice 😎👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming CI is green after the tests run, looks good to merge
#17432 (comment)