Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Make sure scan_ipc does not go through fsspec #17495

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jul 8, 2024

Ref #17444

We have native support now - we should not go through fsspec.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jul 8, 2024
@stinodego stinodego force-pushed the scan-ipc-fix branch 2 times, most recently from f73e384 to 45247b4 Compare July 8, 2024 11:13
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.48%. Comparing base (a899d1f) to head (54cdb1d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17495   +/-   ##
=======================================
  Coverage   80.47%   80.48%           
=======================================
  Files        1483     1482    -1     
  Lines      195136   195112   -24     
  Branches     2782     2778    -4     
=======================================
- Hits       157039   157028   -11     
+ Misses      37585    37573   -12     
+ Partials      512      511    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review July 8, 2024 14:08
@ritchie46 ritchie46 merged commit 5beb022 into main Jul 8, 2024
15 checks passed
@ritchie46 ritchie46 deleted the scan-ipc-fix branch July 8, 2024 15:08
@c-peters c-peters added the accepted Ready for implementation label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants