fix(python): Handle current position of file objects #17543
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17315 introduced an issue that if a file-like object was passed to
read_*
functions, its current stream position was not correctly respected. This PR fixes it by invalidating read buffering of file-like objects and using the stream position as offset when mmapping. This allows e.g. reading a table file with custom heading:If the file is mmapped by reading functions (i.e. in
get_reader_bytes()
), the stream position of the file will not be updated after reading. This PR documents this behavior. Giving that reading functions usually consume all remaining file content and file objects after reading are seldom used anymore, IMO not updating stream position is not a big problem.