test: Name tests so they actually run #17690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
github-actions
bot
added
title needs formatting
internal
MarcoGorelli
commented
Jul 17, 2024
Comment on lines
-51
to
-52
| def is_not_sorted(s: pl.Series) -> bool: | ||
| return not is_sorted_any(s) |
There was a problem hiding this comment.
another drive-by: removing this unused function 👻
MarcoGorelli
commented
Jul 17, 2024
| def index_not_silently_excluded() -> None: | ||
| def test_index_not_silently_excluded() -> None: |
There was a problem hiding this comment.
@tylerriccio33 just fyi, if you name the test index_not_silently_excluded then pytest won't execute it
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17690 +/- ##
==========================================
- Coverage 80.45% 80.45% -0.01%
==========================================
Files 1498 1498
Lines 196456 196454 -2
Branches 2789 2789
==========================================
- Hits 158060 158054 -6
- Misses 37883 37888 +5
+ Partials 513 512 -1 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there's a repeat of #6316 😛
Drive-by: use
MutablePlStringinstead ofMutableBinaryViewArray::<str>