feat: Always preserve sorted flag for .dt.date #18692
Merged
+24
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Sep 11, 2024
Comment on lines
274
to
280
| DataType::Datetime(tu, Some(tz)) => { | ||
| let mut out = { | ||
| polars_ops::chunked_array::replace_time_zone( | ||
| s.datetime().unwrap(), | ||
| None, | ||
| &StringChunked::from_iter(std::iter::once("raise")), | ||
| NonExistent::Raise, | ||
| )? | ||
| .cast(&DataType::Datetime(*tu, None))? | ||
| }; | ||
| if tz != "UTC" { | ||
| // DST transitions may not preserve sortedness. | ||
| out.set_sorted_flag(IsSorted::Not); | ||
| } | ||
| Ok(out) | ||
| }, | ||
| DataType::Datetime(tu, Some(_)) => polars_ops::chunked_array::replace_time_zone( | ||
| s.datetime().unwrap(), | ||
| None, | ||
| &StringChunked::from_iter(std::iter::once("raise")), | ||
| NonExistent::Raise, | ||
| )? | ||
| .cast(&DataType::Datetime(*tu, None)), |
There was a problem hiding this comment.
polars_ops::chunked_array::replace_time_zone already deals with unsetting the sortedness flag if necessary, so this can now be simplified
there's already tests which check sortedness for replacing the time zone:
- test_replace_time_zone_sortedness_series
- test_replace_time_zone_sortedness_expressions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18692 +/- ##
==========================================
+ Coverage 79.86% 79.87% +0.01%
==========================================
Files 1517 1517
Lines 205542 205532 -10
Branches 2892 2892
==========================================
+ Hits 164156 164173 +17
+ Misses 40838 40811 -27
Partials 548 548 ☔ View full report in Codecov by Sentry. |
MarcoGorelli
changed the title
github-actions
bot
added
enhancement
MarcoGorelli
requested review from
ritchie46,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
MarcoGorelli
commented
Sep 12, 2024
Comment on lines
-1378
to
+1377
| pl.Series("ts", [1603584000000000, 1603587600000000]) | ||
| pl.Series("ts", [1603584000000001, 1603587600000000]) |
There was a problem hiding this comment.
@orlp I think this is what you were asking for? like this, the example shows why the sorted flag shouldn't be preserved for 'Europe/London'
|
Can you rebase? |
ritchie46
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.