fix: Fix lit().shrink_dtype() broadcasting
#18958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18958 +/- ##
==========================================
+ Coverage 79.88% 79.94% +0.06%
==========================================
Files 1522 1523 +1
Lines 206958 208002 +1044
Branches 2906 2906
==========================================
+ Hits 165322 166290 +968
- Misses 41088 41164 +76
Partials 548 548 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
|
Oops 👀 |
ritchie46
reviewed
Sep 27, 2024
| @@ -8,7 +8,7 @@ pub fn is_scalar_ae(node: Node, expr_arena: &Arena<AExpr>) -> bool { | |||
| AExpr::Literal(lv) => lv.is_scalar(), | |||
| AExpr::Function { options, input, .. } | |||
| | AExpr::AnonymousFunction { options, input, .. } => { | |||
| if options.is_elementwise() { | |||
| if options.is_elementwise() || !options.flags.contains(FunctionFlags::CHANGES_LENGTH) { | |||
There was a problem hiding this comment.
Ah, yeah.. I feel we need a better flag for this. Now it seems duplicate and tricky. Anyhow. Good fix for now. 👍
ritchie46
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18755