Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizes
List
's variant ofTotalEqKernel
and implements broadcasting for that kernel. This gives a nice speed-up, reduces code-bloat and reduces chance of bugs.For a measure on how much faster this is, I did a microbenchmark:
Time: 16s
Time: 1.9s
I feel like there is more that can be done to make this a lot faster, but I feel like this is good enough for now.