Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean remove_prefix since python3.9 is now the minimum Python #19070

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

  • Python3.9 has removeprefix, so the _remove_prefix utily isn't needed
  • Generator[Any] instead of Generator[Any, None, None] (https://peps.python.org/pep-0696/)
  • walrus operator in some bits where I think it's tasty - it's already used in quite a few places, I guess Polars has already decided to embrace it 😄

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (f7de80c) to head (7e5b615).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/dataframe/frame.py 0.00% 0 Missing and 1 partial ⚠️
py-polars/polars/lazyframe/in_process.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19070      +/-   ##
==========================================
- Coverage   79.80%   79.78%   -0.02%     
==========================================
  Files        1531     1531              
  Lines      208563   208556       -7     
  Branches     2913     2913              
==========================================
- Hits       166437   166405      -32     
- Misses      41575    41600      +25     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review October 6, 2024 15:29
@ritchie46 ritchie46 merged commit c4a28ae into pola-rs:main Oct 6, 2024
13 checks passed
@alexander-beedie
Copy link
Collaborator

image 🙃👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants