fix(rust,python): Allow partial name overlap in join_where resolution #19128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
When checking if both sides of an expression in a `join_where` call are from the right table (for which overlapping names will be suffixed) we must exclude undecorated names which also appear in the left table. - Closes pola-rs#19119
wence-
force-pushed
the
wence/fix/19119
branch
from
7f19394 to
e6704b8
Compare
wence-
changed the title
wence-
commented
Oct 8, 2024
| options.args.suffix.as_deref(), | ||
| options.args.suffix().as_str(), |
There was a problem hiding this comment.
This is drive-by, can split out.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19128 +/- ##
==========================================
- Coverage 79.79% 79.76% -0.04%
==========================================
Files 1531 1531
Lines 208611 208434 -177
Branches 2913 2913
==========================================
- Hits 166453 166247 -206
- Misses 41607 41636 +29
Partials 551 551 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if both sides of an expression in a
join_wherecall are from the right table (for which overlapping names will be suffixed) we must exclude undecorated names which also appear in the left table.join_whereraisesInvalidOperationwhen right frame contains names from left frame and some additional ones #19119