fix: Only apply string parsing to String dtype #19222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balbok0
changed the title
github-actions
bot
added
fix
balbok0
force-pushed
the
remove-binary-to-numerical
branch
from
f626a40 to
24f1921
Compare
balbok0
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19222 +/- ##
==========================================
+ Coverage 79.68% 80.00% +0.32%
==========================================
Files 1532 1528 -4
Lines 209202 209563 +361
Branches 2416 2415 -1
==========================================
+ Hits 166706 167668 +962
+ Misses 41948 41347 -601
Partials 548 548 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #18991 for comment and conclusion. This MR is step 1 of proposed solution.
It is technically breaking, but old version of transform
binary -> numericalcan be done viabinary -(decode)> string -> numerical).Note that I wasn't sure what was going on with
Decimalsince it is allowed in string, but not for binary. I removed it, but please let me know if it should be interpreted somehow