Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Add groupby partitioning and parallel groupby finishing to new-streaming engine #19451

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 25, 2024

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 1.10497% with 358 lines in your changes missing coverage. Please review.

Project coverage is 79.81%. Comparing base (1452468) to head (21ad2b7).
Report is 95 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/bitmap/builder.rs 0.00% 66 Missing ⚠️
crates/polars-expr/src/reduce/partition.rs 0.00% 65 Missing ⚠️
crates/polars-stream/src/nodes/group_by.rs 0.00% 65 Missing ⚠️
crates/polars-expr/src/groups/row_encoded.rs 0.00% 63 Missing ⚠️
crates/polars-expr/src/reduce/mod.rs 0.00% 38 Missing ⚠️
crates/polars-expr/src/reduce/min_max.rs 0.00% 36 Missing ⚠️
crates/polars-expr/src/reduce/sum.rs 0.00% 15 Missing ⚠️
crates/polars-expr/src/reduce/len.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19451      +/-   ##
==========================================
- Coverage   79.97%   79.81%   -0.17%     
==========================================
  Files        1533     1536       +3     
  Lines      210916   211401     +485     
  Branches     2442     2444       +2     
==========================================
+ Hits       168688   168732      +44     
- Misses      41673    42114     +441     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp marked this pull request as ready for review October 28, 2024 11:53
@ritchie46 ritchie46 merged commit 00b4d61 into pola-rs:main Oct 28, 2024
20 checks passed
@c-peters c-peters added the accepted Ready for implementation label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants