fix: Fix filter scalar nulls #19786
Merged
fix: Fix filter scalar nulls #19786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
orlp
requested changes
Nov 14, 2024
| @@ -280,6 +280,11 @@ impl SeriesTrait for NullChunked { | |||
| // We still allow a length of `1` because it could be `lit(true)`. | |||
| polars_ensure!(filter.len() <= 1, ShapeMismatch: "filter's length: {} differs from that of the series: 0", filter.len()); | |||
| 0 | |||
| } else if filter.len() == 1 { | |||
| return match filter.get(0) { | |||
| None | Some(true) => Ok(self.clone().into_series()), | |||
There was a problem hiding this comment.
I believe that None should be in the false branch, not behave like true.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19786 +/- ##
==========================================
- Coverage 79.55% 79.54% -0.02%
==========================================
Files 1544 1546 +2
Lines 213240 213511 +271
Branches 2441 2444 +3
==========================================
+ Hits 169645 169829 +184
- Misses 43046 43132 +86
- Partials 549 550 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19771