-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure List
element truncation ellipses respect ASCII*
table formats
#19835
fix: Ensure List
element truncation ellipses respect ASCII*
table formats
#19835
Conversation
b517846
to
9f59870
Compare
9f59870
to
05b232e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19835 +/- ##
=======================================
Coverage 79.33% 79.33%
=======================================
Files 1548 1548
Lines 214245 214237 -8
Branches 2460 2460
=======================================
+ Hits 169968 169972 +4
+ Misses 43719 43707 -12
Partials 558 558 ☔ View full report in Codecov by Sentry. |
List
element truncation ellipses respect ASCII formatList
element truncation ellipses respect ASCII*
table formats
Thanks @alexander-beedie - this is slightly out of scope for this PR, but I wonder if we should adopt the Oxford comma? e.g. from
to
|
We should not - it gives up valuable horizontal space for no obvious gain ;) The only reference I found (after an admittedly very casual search!) talking about this situation seems to agree:
|
I see, that makes sense. Though I will say that mathematical writing follows the opposite convention of including the Oxford comma in this context. |
Yup. Different domain; here we prioritise visualisation and effective use of horizontal space. The priority in a mathematical domain will understandably err towards formal precision. Each is appropriate in their respective context 👍 |
Closes #19821.
Follows-up #19404, which missed the
List
dtype ellipsis truncation.Example
Before:
(utf8 ellipsis char used in ascii table)
After:
(ascii ellipsis chars)