Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix lazy frame join expression #19974

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Conversation

stijnherfst
Copy link
Collaborator

Fixes #19822

Previously only the first column was added to the local projections while all of the columns in the sub expression should be added.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (6c34d59) to head (ab2d8e6).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19974      +/-   ##
==========================================
+ Coverage   79.40%   79.48%   +0.07%     
==========================================
  Files        1550     1556       +6     
  Lines      214909   216394    +1485     
  Branches     2447     2456       +9     
==========================================
+ Hits       170653   172003    +1350     
- Misses      43699    43833     +134     
- Partials      557      558       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ritchie46 ritchie46 merged commit 41e13c6 into pola-rs:main Nov 25, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with join and selectors in LazyFrames (equivalent code works for eager DataFrames)
2 participants