Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrectly gave list.len() for masked-out rows #19999

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #19987

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 26, 2024
Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #19999 will improve performances by 27.62%

Comparing nameexhaustion:list-lengths-validity (7ef977b) with main (d9ea1d8)

Summary

⚡ 1 improvements
✅ 40 untouched benchmarks

Benchmarks breakdown

Benchmark main nameexhaustion:list-lengths-validity Change
test_pdsh_q18 16.5 ms 12.9 ms +27.62%

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.49%. Comparing base (0b1d520) to head (7ef977b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19999      +/-   ##
==========================================
- Coverage   79.49%   79.49%   -0.01%     
==========================================
  Files        1556     1556              
  Lines      216407   216416       +9     
  Branches     2456     2456              
==========================================
+ Hits       172043   172044       +1     
- Misses      43806    43814       +8     
  Partials      558      558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review November 26, 2024 12:21
@ritchie46 ritchie46 merged commit e5f0b97 into pola-rs:main Nov 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list.len() reports len of a list that no longer exists
2 participants