Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(rust): Fix inconsistency between code and comment #20070

Merged
merged 2 commits into from
Dec 2, 2024
Merged

docs(rust): Fix inconsistency between code and comment #20070

merged 2 commits into from
Dec 2, 2024

Conversation

YichiZhang0613
Copy link
Contributor

@YichiZhang0613 YichiZhang0613 commented Nov 30, 2024 •
edited
Loading

Fix #20073

@github-actions github-actions bot added documentation Improvements or additions to documentation rust Related to Rust Polars labels Nov 30, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (ca8c1ef) to head (b33869b).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #20070   +/-   ##
=======================================
  Coverage   79.53%   79.53%           
=======================================
  Files        1563     1563           
  Lines      217124   217124           
  Branches     2464     2464           
=======================================
+ Hits       172680   172683    +3     
+ Misses      43884    43881    -3     
  Partials      560      560

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MarcoGorelli
MarcoGorelli approved these changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't familiar with this part of the code, but by inspecting the implementations around the comments, your corrections look good

@ritchie46 ritchie46 merged commit ac4822b into pola-rs:main Dec 2, 2024
21 checks passed
nimit pushed a commit to nimit/polars that referenced this pull request Dec 2, 2024
@YichiZhang0613 @nimit
docs(rust): Fix inconsistency between code and comment (pola-rs#20070)
f00e6fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in comments
3 participants
@YichiZhang0613 @MarcoGorelli @ritchie46