Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Materialize smallest dyn ints to use feature gate for i8/i16 #20108

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

lukemanley
Copy link
Contributor

Based on this comment: #20075 (comment)

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 2, 2024
@lukemanley lukemanley marked this pull request as ready for review December 2, 2024 12:01
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.52%. Comparing base (58f763a) to head (edcd377).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/utils/supertype.rs 83.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20108      +/-   ##
==========================================
- Coverage   79.53%   79.52%   -0.01%     
==========================================
  Files        1563     1563              
  Lines      217115   217117       +2     
  Branches     2464     2464              
==========================================
- Hits       172679   172671       -8     
- Misses      43876    43886      +10     
  Partials      560      560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit e6a3d37 into pola-rs:main Dec 3, 2024
20 checks passed
@lukemanley lukemanley deleted the dyn-int-types branch December 6, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants