Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle slice pushdown in PythonUDF GroupBy #20132

Merged

Conversation

coastalwhite
Copy link
Collaborator

Fixes #20002.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 59.00%. Comparing base (d86e44b) to head (0104e82).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/frame/group_by/mod.rs 0.00% 8 Missing ⚠️
crates/polars-mem-engine/src/executors/group_by.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #20132       +/-   ##
===========================================
- Coverage   79.52%   59.00%   -20.52%     
===========================================
  Files        1563     1563               
  Lines      217186   217203       +17     
  Branches     2465     2465               
===========================================
- Hits       172715   128170    -44545     
- Misses      43910    88472    +44562     
  Partials      561      561               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite merged commit bf8f64c into pola-rs:main Dec 3, 2024
26 checks passed
@coastalwhite coastalwhite deleted the fix/map-groups-slice-pushdown branch December 3, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect head(n) result following map_groups with "slice_pushdown" optimisation enabled
2 participants