Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Retry with reloaded credentials on cloud error #20185

Merged
merged 6 commits into from
Dec 7, 2024
Merged

feat: Retry with reloaded credentials on cloud error #20185

merged 6 commits into from
Dec 7, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Dec 6, 2024 •
edited
Loading

ref #19933

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 6, 2024
@nameexhaustion nameexhaustion force-pushed the cloud-err-rebuild branch 2 times, most recently from 72a3b2a to cd409cc Compare December 6, 2024 09:58
nameexhaustion
nameexhaustion commented Dec 6, 2024
View reviewed changes
crates/polars-io/src/cloud/glob.rs
@@ -74,13 +75,13 @@ pub(crate) fn extract_prefix_expansion(url: &str) -> PolarsResult<(String, Optio
#[derive(PartialEq, Debug, Default)]
pub struct CloudLocation {
/// The scheme (s3, ...).
pub scheme: String,
pub scheme: PlSmallStr,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by PlSmallStr as these tend to be small

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.83965% with 52 lines in your changes missing coverage. Please review.

Project coverage is 79.64%. Comparing base (39550c0) to head (3fda7f3).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/cloud/polars_object_store.rs 82.15% 38 Missing ⚠️
crates/polars-io/src/cloud/object_store_setup.rs 81.15% 13 Missing ⚠️
crates/polars-io/src/path_utils/hugging_face.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20185      +/-   ##
==========================================
+ Coverage   79.63%   79.64%   +0.01%     
==========================================
  Files        1564     1564              
  Lines      217800   217947     +147     
  Branches     2477     2477              
==========================================
+ Hits       173439   173588     +149     
+ Misses      43792    43791       -1     
+ Partials      569      568       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review December 6, 2024 12:24
@ritchie46 ritchie46 merged commit fdaf517 into pola-rs:main Dec 7, 2024
24 of 25 checks passed
@c-peters c-peters added the accepted Ready for implementation label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees

@nameexhaustion nameexhaustion

Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nameexhaustion @ritchie46 @c-peters