Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow row encoding for 32-bit architectures (e.g. WASM) #20186

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #17192.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.61%. Comparing base (36b1244) to head (b0eecbc).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-row/src/row.rs 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20186      +/-   ##
==========================================
- Coverage   79.63%   79.61%   -0.02%     
==========================================
  Files        1564     1564              
  Lines      217472   217707     +235     
  Branches     2474     2475       +1     
==========================================
+ Hits       173188   173333     +145     
- Misses      43715    43805      +90     
  Partials      569      569              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgv
Copy link
Contributor

kgv commented Dec 6, 2024

checked, fixes my case, thx for PR.

@ritchie46 ritchie46 merged commit c92612a into pola-rs:main Dec 7, 2024
20 of 21 checks passed
@coastalwhite coastalwhite deleted the fix/32bit-row-encoding branch December 7, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group By no longer supported in Rust WASM
3 participants