Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't trigger length check in array construction #20205

Merged
merged 8 commits into from
Dec 7, 2024
Merged

fix: Don't trigger length check in array construction #20205

merged 8 commits into from
Dec 7, 2024

Conversation

ritchie46
Copy link
Member

fixes #20200

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 91.39785% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (c92612a) to head (2b792ae).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/series/utils.py 70.00% 3 Missing ⚠️
crates/polars-core/src/chunked_array/mod.rs 91.66% 2 Missing ⚠️
...rc/chunked_array/logical/categorical/ops/append.rs 83.33% 1 Missing ⚠️
...ates/polars-core/src/chunked_array/ops/chunkops.rs 91.66% 1 Missing ⚠️
...s/polars-plan/src/dsl/function_expr/range/utils.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #20205    +/-   ##
========================================
  Coverage   79.62%   79.62%            
========================================
  Files        1564     1565     +1     
  Lines      217989   218187   +198     
  Branches     2477     2475     -2     
========================================
+ Hits       173564   173741   +177     
- Misses      43857    43879    +22     
+ Partials      568      567     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d4bab3f into main Dec 7, 2024
26 checks passed
@ritchie46 ritchie46 deleted the len branch December 7, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
1 participant