feat: Add bin.reinterpret
#20263
Merged
feat: Add bin.reinterpret
#20263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balbok0
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20263 +/- ##
==========================================
- Coverage 79.60% 79.60% -0.01%
==========================================
Files 1565 1567 +2
Lines 218396 218413 +17
Branches 2477 2465 -12
==========================================
Hits 173860 173860
- Misses 43970 43984 +14
- Partials 566 569 +3 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Dec 13, 2024
| to, | ||
| is_little_endian, | ||
| ))) | ||
| } |
| (pl.Int32, 4, "i"), | ||
| (pl.UInt32, 4, "I"), | ||
| (pl.Int64, 8, "q"), | ||
| (pl.UInt64, 8, "Q"), |
There was a problem hiding this comment.
Can we test pl.Int128 as well?
There was a problem hiding this comment.
fixed.
Although, I should note that struct or numpy doesn't support ints. I created a second test function meant specifically for exotic ints (since it seems that UInt128 is WIP).
Reason to keep the old one, and not switch to this approach is the fact that float doesn't have to_bytes function.
balbok0
force-pushed
the
add-binary-as-numerical-updated
branch
from
801ad75 to
417f6dc
Compare
ritchie46
changed the title
bin.reinterpret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #18991 Follow-up to #19542
Addressed comments from previous MR, although please let me know if the placement of code is still not where it is expected.
Implements from_buffer method that casts from Binary to Numerical types. It is not the most efficient (i.e. size + reinterpret cast would probably better), but provides a consistent code for both LE and BE encodings. Name is inspired by numpy equivalent, but with polars style _ separator between words.
I also added match arm in cast that goes from Binary -> numerical type. It assumes LE encoding, as it is a vastly more popular from the two. Happy to remove that part of code, since it does make an unspecified assumption. Lastly, I noticed that there is missing Numerical -> Binary functionality. Out-of-scope for this MR IMO, but something I can do later on.