Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Don't rely on argument order of optimization_toggle #20622

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 8, 2025

Makes me uncomfortable we were relying on argument order in optimization_toggle for 10+ boolean arguments in a bunch of places.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Jan 8, 2025
@ritchie46
Copy link
Member

Yeah, can get behind that. :D

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (044bc51) to head (93719f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20622   +/-   ##
=======================================
  Coverage   79.04%   79.04%           
=======================================
  Files        1557     1557           
  Lines      220519   220519           
  Branches     2510     2510           
=======================================
+ Hits       174303   174305    +2     
+ Misses      45642    45640    -2     
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 8ec4379 into pola-rs:main Jan 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants