-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow for more RG skipping by rewriting expr in planner #20828
Merged
coastalwhite
merged 26 commits into
pola-rs:main
from
coastalwhite:feat/pred-to-skip-batches-expr
Jan 30, 2025
Merged
feat: Allow for more RG skipping by rewriting expr in planner #20828
coastalwhite
merged 26 commits into
pola-rs:main
from
coastalwhite:feat/pred-to-skip-batches-expr
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
labels
Jan 21, 2025
This is now basically done, only a few more things need to happen:
|
coastalwhite
force-pushed
the
feat/pred-to-skip-batches-expr
branch
2 times, most recently
from
January 23, 2025 15:05
1716ad7
to
0e6f163
Compare
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
January 24, 2025 11:05
coastalwhite
force-pushed
the
feat/pred-to-skip-batches-expr
branch
from
January 24, 2025 15:49
52aa4a4
to
6304cb1
Compare
This is an drafting PR to show the idea of rewriting the predicate expression in the planner to an expression that can be used to skip record batches (row groups in parquet). At the moment this is probably already close to what the existing implementation can do even with some more to show that it is better (by implementing `Expr.is_in`). [skip ci]
coastalwhite
force-pushed
the
feat/pred-to-skip-batches-expr
branch
from
January 27, 2025 08:55
b60cbc8
to
1f79264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accepted
Ready for implementation
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an drafting PR to show the idea of rewriting the predicate expression in the planner to an expression that can be used to skip record batches (row groups in parquet).
At the moment this is probably already close to what the existing implementation can do even with some more to show that it is better (by implementing
Expr.is_in
).