Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Implement negative slice for new streaming IPC #20866

Merged
merged 2 commits into from
Jan 24, 2025
Merged

chore: Implement negative slice for new streaming IPC #20866

merged 2 commits into from
Jan 24, 2025

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jan 23, 2025
@coastalwhite coastalwhite marked this pull request as draft January 23, 2025 11:55
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes missing coverage. Please review.

Project coverage is 79.74%. Comparing base (aa1b45f) to head (e86c05b).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/io_sources/ipc.rs 0.00% 67 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20866      +/-   ##
==========================================
+ Coverage   79.64%   79.74%   +0.10%     
==========================================
  Files        1571     1566       -5     
  Lines      223185   222559     -626     
  Branches     2554     2572      +18     
==========================================
- Hits       177749   177478     -271     
+ Misses      44851    44489     -362     
- Partials      585      592       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite marked this pull request as ready for review January 24, 2025 12:37
@ritchie46 ritchie46 merged commit 332bd7d into pola-rs:main Jan 24, 2025
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees

@coastalwhite coastalwhite

Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coastalwhite @ritchie46 @c-peters