Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min()/max() with nan #330

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Fix min()/max() with nan #330

merged 2 commits into from
Feb 4, 2021

Conversation

elbaro
Copy link
Contributor

@elbaro elbaro commented Feb 4, 2021 •
edited
Loading

Fix #328

@ritchie46
Copy link
Member

I believe that we can use the arrow kernels as the problem should be fixed upstream by now.

@ritchie46
Copy link
Member

Thanks for your PR. The kernels still have this behavior, so we'll stay on the local implementation until that is fixed.

@ritchie46 ritchie46 merged commit fd9c83c into pola-rs:master Feb 4, 2021
@elbaro elbaro deleted the min-max-nan-fix branch February 4, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

min()/max() behaves different with nan
2 participants
@elbaro @ritchie46