fix(python, rust): Only consider dt series equal if they have the same tz #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteosantama
force-pushed
the
series-equal-tz
branch
4 times, most recently
from
5805e8a to
3a1c112
Compare
matteosantama
force-pushed
the
series-equal-tz
branch
from
3a1c112 to
7921a2d
Compare
|
Make sense. Thanks! |
stinodego
changed the title
stinodego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5023
I briefly debated allowing two series to be considered equal if they had different timezones provided they represented the same UTC time. But I think this is more likely to lead to unexpected behavior. It is more explicit, and clearer, to require users to explicitly convert their datetimes to a canonical timezone before checking for equality.