fix(rust, python): Implement missing extract
conversion for Time
datatype
#5161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing
extract
conversion forTime
, allowingFromPyObject
to handle python times (in addition to already-supported datetimes/dates).Example
Before: (panic with
RuntimeError
on unsupported type)After: (successful use/return of python
time
)Misc:
FromPyObject
were done withcontains
; seems safer to useeq
to avoid potential (if unlikely) mismatches, unless there's a reason not to?object => pl.Object
as a valid_PY_TYPE_TO_DTYPE
lookup.